Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MET+MHT+b-tag Offline DQM 92X #19508

Closed
wants to merge 69 commits into from
Closed

MET+MHT+b-tag Offline DQM 92X #19508

wants to merge 69 commits into from

Conversation

jmduarte
Copy link
Member

@jmduarte jmduarte commented Jul 2, 2017 •
edited
Loading

These changes depend on the PRs #19293 (MET paths) and #19119 (b-tag paths). I can rebase once these are merged.

My commits are only the final two:
https://github.com/cms-sw/cmssw/pull/19508/files/3354e5e5d53ef285be8fbc062c9f474c2d29c309..4ed4df680ee8e276db9dd1574e59ad1d8ba2ca8a

defranchis and others added 30 commits May 27, 2017 10:36
@defranchis
Offline DQM for Top HLT
b8c78ae
@defranchis
adding electron isolation for ele+jets
552890e
@defranchis
adding variable binning + multiplicity histograms
8173416
@defranchis
Merge pull request cms-sw#5 from defranchis/DQM-try-to-cherrypick
01b00c3 
adding variable binning + multiplicity histograms
@defranchis
adding 2D histograms and efficiencies
b68cbb0
@defranchis
renaming directories
26414c6
@defranchis
updating from EDAnalyzer to DQMEDHarvester
5303a4a
@defranchis
adding further 2D distributions for di-lepton channel
7ae70ef
@defranchis
configuring variable binning
3003514
@defranchis
bug fix
f35341a
@defranchis
updating selection for ele+jets
6286bc3
@defranchis
updating pt binnings
5fbdb04
@mohsinwaseem
Updated Leptonic Paths
7735713
@mohsinwaseem
Reverted changes in HLTriggerOffline
bb8267c
@defranchis
Merge pull request cms-sw#9 from mohsinwaseem/Test
dd87c03 
Updated Leptonic Paths
@marinakolosova @defranchis
merging code for fully-hadronic
cf5a011
@defranchis
adding default CSV working point
5611aef
@defranchis
Merge pull request cms-sw#10 from defranchis/merge-from-fully-hadronic
1b97155 
Merge from fully hadronic
@sroychow
update top hlt dqm code to include PV cuts to be used by higgs montoring
61e8d65
@defranchis
adding string selection for b-jets
79cfa0e
@defranchis
removing single top and updating output directories
5f380f1
@defranchis
optimization and bug fix
0ae26fa
@defranchis
Merge pull request cms-sw#12 from defranchis/merge-from-fully-hadronic
29ea8cc 
Merge from fully hadronic
@sroychow
Merge branch 'TopDQMOfflineHLT' into updateTotopdqm
40849d4
@sroychow
resolving conflicts with previous updates from bjet
c817647
@marinakolosova
Added Reference Monitoring
c7e5018
@defranchis
Merged refs/pull/18981/head from repository cms-sw
3b6908a
@defranchis
adding BTagMu and PFJet monitorning for AK4 and AK8
b8f531d
@defranchis
Merge pull request cms-sw#13 from marinakolosova/newPR_fullyhadronic
5b9627b 
Added Reference Monitoring
@defranchis
Merge pull request cms-sw#11 from sroychow/updateTotopdqm
a0f4163 
Update top hlt dqm code to include PV cuts to be used by higgs montoring
@jmduarte
Copy link
Member Author

jmduarte commented Jul 3, 2017

I rearranged the folders so the DQM histograms will live in HLT/Higgs/

The last two commits are the only ones on top of #19119 #19293:
https://github.com/cms-sw/cmssw/pull/19508/files/3354e5e5d53ef285be8fbc062c9f474c2d29c309..4ed4df680ee8e276db9dd1574e59ad1d8ba2ca8a

@fwyzard
Copy link
Contributor

fwyzard commented Jul 3, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21113/console Started: 2017/07/04 01:06
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21114/console Started: 2017/07/04 01:33

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

+1
Tested at: 4ed4df6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19508/21114/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3354e5e
d1004d4
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19508/21114/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19508/21114/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19508/21114/summary.html

Comparison Summary:

  • You potentially added 242 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813730
  • DQMHistoTests: Total failures: 29914
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783650
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@mtosi
Copy link
Contributor

mtosi commented Jul 6, 2017

do we have the analogous PR for the master (93x) ?

@jmduarte jmduarte changed the title MET+MHT+b-tag Offline DQM MET+MHT+b-tag Offline DQM 92X Jul 6, 2017
@jmduarte jmduarte mentioned this pull request Jul 6, 2017
Merged
@jmduarte
Copy link
Member Author

jmduarte commented Jul 6, 2017

93X version of PR is here: #19596

@mtosi
Copy link
Contributor

mtosi commented Jul 6, 2017

in the silvio's google doc I find

HLT_PFMET100_PFMHT100_IDTight_BTagCaloCSV_p7_v*
HLT_PFMET110_PFMHT110_IDTight_BTagCaloCSV_p7_v*
HLT_PFMET120_PFMHT120_IDTight_BTagCaloCSV_p7_v*
HLT_PFMET130_PFMHT130_IDTight_BTagCaloCSV_p7_v*
HLT_PFMET140_PFMHT140_IDTight_BTagCaloCSV_p7_v*
!!!!

can we converge to the name of those trigger paths, please ?

@jmduarte
Copy link
Member Author

jmduarte commented Jul 6, 2017

Yes, sorry, I renamed them as requested by TSG rather late... I asked @silviodonato to rename them in the google doc and the master table in the JIRA ticket:

https://its.cern.ch/jira/browse/CMSHLT-1391

The DQM PR here always refer to the p05 (mistag efficiency) names.

Thanks,

Javier

@fwyzard
Copy link
Contributor

fwyzard commented Jul 6, 2017

I renamed them as requested by TSG rather late...

The "request" was actually agreed between TSG and b-tagging POG one year ago.
Then they apparently forgot.

.A

@fwyzard
Copy link
Contributor

fwyzard commented Jul 25, 2017

Hi,
given the amount of stuff that needs to be backported, I plan to do it in a single PR as soon as the DQM for the HLT menu v2.1 is fully integrated in 9.3.x.
If the 9.3.x equivalent of this PR has already been merged, or is listed as "Open" at #19412, can you close this PR ?

@jmduarte
Copy link
Member Author

Hi @fwyzard, I assume you mean #19142.

In that PR, I do see the 93X version of this PR #19596 with the status "Open" (only ORP pending).

Given that, I'll close this PR.

Thanks,

Javier

@jmduarte jmduarte closed this Jul 26, 2017
@jmduarte jmduarte deleted the met-mht-b-tag-dqm-92x branch July 28, 2023 13:58
@jmduarte jmduarte restored the met-mht-b-tag-dqm-92x branch July 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtosi mtosi mtosi left review comments

Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.